Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/improve fusion #2773

Merged
merged 38 commits into from
Feb 6, 2025
Merged

Feat/improve fusion #2773

merged 38 commits into from
Feb 6, 2025

Conversation

nathanielsimard
Copy link
Member

@nathanielsimard nathanielsimard commented Feb 3, 2025 •
edited
Loading

Added support for broadcasting, mix vectorization and fused reshape operation. There is also a big refactoring of the fusion code to manage the added complexity.

@nathanielsimard nathanielsimard mentioned this pull request Feb 3, 2025
Merged
@codecov Codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.92476% with 179 lines in your changes missing coverage. Please review.

Project coverage is 83.67%. Comparing base (00422c1) to head (7f596f0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/burn-jit/src/fusion/on_write/io.rs 54.85% 93 Missing ⚠️
...tes/burn-jit/src/fusion/on_write/trace/executor.rs 70.28% 41 Missing ⚠️
...ates/burn-jit/src/fusion/on_write/trace/builder.rs 86.07% 11 Missing ⚠️
crates/burn-jit/src/fusion/matmul/args.rs 0.00% 7 Missing ⚠️
crates/burn-jit/src/fusion/on_write/builder.rs 94.40% 7 Missing ⚠️
...rates/burn-jit/src/fusion/on_write/trace/runner.rs 92.13% 7 Missing ⚠️
...urn-jit/src/fusion/on_write/trace/vectorization.rs 88.67% 6 Missing ⚠️
crates/burn-jit/src/fusion/on_write/kernel.rs 25.00% 3 Missing ⚠️
crates/burn-jit/src/fusion/on_write/ir.rs 93.10% 2 Missing ⚠️
...rates/burn-jit/src/fusion/on_write/trace/output.rs 99.34% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2773      +/-   ##
==========================================
+ Coverage   83.63%   83.67%   +0.03%     
==========================================
  Files         826      832       +6     
  Lines      108752   109524     +772     
==========================================
+ Hits        90960    91643     +683     
- Misses      17792    17881      +89

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

laggui
laggui approved these changes Feb 6, 2025
View reviewed changes
crates/burn-jit/src/fusion/on_write/trace/output.rs Outdated Show resolved Hide resolved
crates/burn-jit/src/fusion/on_write/trace/plan.rs Outdated Show resolved Hide resolved
@laggui laggui merged commit 6015823 into main Feb 6, 2025
11 checks passed
@laggui laggui deleted the feat/fuse-reshape branch February 6, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laggui laggui laggui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanielsimard @laggui